[Translation] added logging capability.#4050
Closed
aitboudad wants to merge 1 commit intosymfony:masterfrom
Closed
[Translation] added logging capability.#4050aitboudad wants to merge 1 commit intosymfony:masterfrom
aitboudad wants to merge 1 commit intosymfony:masterfrom
Conversation
Contributor
aitboudad
commented
Jul 23, 2014
aitboudad
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes(symfony/symfony/pull/10887) |
| Applies to | 2.6+ |
| Fixed tickets | - |
book/translation.rst
Outdated
Member
There was a problem hiding this comment.
both "Missing" and "Message" should be capitialized since they are not closed-class words
Member
|
I think it's a bit too long for the book chapter and a bit too short in the config reference. What do you think about moving the information about the |
Member
|
Can you add [WCM](which means Waiting Code Merge) to the pull request title? |
aitboudad
changed the title
Contributor
Author
|
@xabbuh done :) |
book/translation.rst
Outdated
Member
There was a problem hiding this comment.
Something like "The ability to log missing translations was introduced in Symfony 2.6" sounds better to me.
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 24, 2014
This PR was squashed before being merged into the 2.6-dev branch (closes #10887). Discussion ---------- [Translation] added LoggingTranslator. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #3015, #2435 | License | MIT | Doc PR | symfony/symfony-docs/pull/4050 Commits ------- b7770bc [Translation] added LoggingTranslator.
aitboudad
changed the title
book/translation.rst
Outdated
Contributor
There was a problem hiding this comment.
Let's add a link to the new spot in the reference section. That way, people can see this is for debug mode only by default, but they can configure it.
aitboudad
force-pushed
the
ticket_3015
branch
from
1ad2378 to
0c048dd
Compare
Member
|
Looks good to me. 👍 |
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2014
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #4050). Discussion ---------- [Translation] added logging capability. | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes(symfony/symfony/pull/10887) | Applies to | 2.6+ |Fixed tickets | - Commits ------- e8e50fa added logging to translator.
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2014
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2014
* 2.3: [#4050] Backporting some additions to 2.3 Missing attribute 'original' Fixes concat operator typo Incorporates @wouterj 's suggestion for more realistic usage of bang Changes operator spacing language Adds missing space before return statement Fixes spelling and formatting errors Fixes wrong bullet character Adds bullet addressing bang placement Reverses statement about bang spacing and corresponding examples [RFC] Clarification on formatting for bangs (!) remove first person as per feedback capitalize section title as per feedback instructions for setting SYMFONY_ENV on Heroku for smooth deploys Change: ConsoleTerminateListener => ErrorLoggerListener Removed parameters from service Fix typos in code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.